Skip to content
Cockpit0.29.0
A snapshot: read at commit 707a04c7ce8 on 2026-10-18T00:06:01Z by majordomus 0.29.0. Nothing on this page is read again. See it live

I2415

A mesh review request carries a body, can be withdrawn, and expires

Where it stands

devtask.issue
Readiness
ready no dependency and no gate holds it; nobody has started it
Status
READY
Can start
startable
Milestone
Milestone status
PLANNED
Wave
0
Waiting on
none
Holds back
none
Behind it in all
0
Evidence
0 of 1
A move writes the repository: it stamps one field of this issue's record and appends one event to the ledger, and a commit will carry both.
The same moves from a terminal

majordomus plan start I2415

majordomus plan verify I2415

majordomus plan done I2415

What it is

Objective
Give review requests a body beside the 256-byte subject, a withdraw event its requester may write, an optional expiry, and a result note the requester may attach to its own request, so a request ends instead of staying open forever.
Why
ReviewRequested has a subject capped at 256 bytes and no body (apps/majordomus-cli/src/mesh/journal.rs:520-536, 702); ReviewState is only Open or Answered (state.rs:341-346); KNOWN_KINDS has no close or expiry (journal.rs:553-561); and a requester cannot answer its own request (cooperation.rs:3617-3620). On 2026-10-10 pre-flight requests for rebuilt, void heads stayed open, and results had to be posted as new requests.
Now
Requests stay open until someone else answers; no body, no withdrawal, no expiry.
Wanted
body up to 8 KiB; review_withdrawn by the requester; expires_at honoured by the fold; a requester's own result note linked to its request without counting as another session's verdict.
Done when
unknown: the record declares no `completion`
Risk
unknown: the record declares no `risk`

Acceptance

  • A request with an 8 KiB body replicates and folds on two runtimes
  • A withdrawn or expired request folds to a closed state on every runtime
  • A requester's result note is shown with its request and is not an answer
Validation
bin/majordomus plan validatecargo test --lib mesh::
Evidence required
review_lifecycle_test
Evidence present
unknown: the record carries no `evidence` entries

Scope

Touches
apps/majordomus-cli/src/mesh/journal.rsapps/majordomus-cli/src/mesh/state.rsapps/majordomus-cli/src/mesh/cooperation.rsapps/majordomus-cli/src/capability/builtin/mesh.rsdocs/MESH.md
Not
unknown: the record declares no `non_scope`
Depends on
unknown: the record declares no `depends_on`
Priority
p2
Profile
implementation
Parallel safe
true
Owner
unknown: the record declares no `owner`

The work so far

Branches
none
Merged
none
Commits
0
Trunk
master
Sessions
none
Created
2026-10-10
Updated
2026-10-10
Started
unknown: the record declares no `started_at`
Verified
unknown: the record declares no `verified_at`
Completed
unknown: the record declares no `completed_at`

Synchronisation

Adapter
scripts/github-sync
Repository
unknown: the derived plan's header carries no repository
External issue
unknown: a live GitHub state; this executable makes no network call, so only `scripts/github-sync --check` can answer it
State there
unknown: a live GitHub state; this executable makes no network call, so only `scripts/github-sync --check` can answer it

Findings

LevelCodeMessageReproduce
WARNscope_conflictshares apps/majordomus-cli/src/capability/builtin/mesh.rs with I2720; they may not run concurrentlymajordomus plan validate
WARNscope_conflictshares apps/majordomus-cli/src/mesh/journal.rs with I2723; they may not run concurrentlymajordomus plan validate