I3419 — A conclusion's independent review count counts distinct sources, defined as adapter plus recorded model, so two answers from one source are one review
Define a source as the adapter plus the recorded model. A mesh-review consultation that reported no model counts as the adapter plus the answering peer runtime, and any other consultation without a model counts as the adapter alone. Compute independent_review_count and the task totals' independent reviewers from distinct sources instead of distinct advisor ids, and list the sources a conclusion was reviewed by.
BLOKOVÁNO vlna 2 · p1 · profil implementation · bezpečné paralelně
Blocked. This issue cannot start until I3418, milestone:an-inference-names-its-source-and-budget are done. The status is derived from that, not declared.
Cíl
Define a source as the adapter plus the recorded model. A mesh-review consultation that reported no model counts as the adapter plus the answering peer runtime, and any other consultation without a model counts as the adapter alone. Compute independent_review_count and the task totals' independent reviewers from distinct sources instead of distinct advisor ids, and list the sources a conclusion was reviewed by.
Proč
The owner's 2026-10-19 Cognitive Fabric pack asks for source diversity rather than a vote count, and names duplicate models through one adapter as a required test (campaigns/prismatic-way-cognitive-fabric-prompt-pack/prompts/04_REASONING_MESH.md).
Aktuální stav
Selection treats an adapter as one source (apps/majordomus-cli/src/reasoning/policy.rs:356-358). The conclusion writer adds each distinct advisor id to reviewed_by (store.rs:789-791) and counts it (store.rs:841-843), so two mesh peers through the one mesh-review adapter count as two independent reviews.
Cílový stav
reviewed_by stays the advisors cited. reviewed_sources lists the distinct sources, and independent_review_count equals its length. The records check of reasoning check recomputes the count.
Rozsah
- apps/majordomus-cli/src/reasoning/store.rs
- apps/majordomus-cli/src/reasoning/state.rs
- apps/majordomus-cli/src/reasoning/check.rs
- docs/REASONING.md
Mimo rozsah
- Changing advisor selection order
- Weighting answers by source
Závislosti
Co na tom čeká
Kritéria přijetí
- Two completed consultations through one adapter with the same model give independent_review_count 1
- Two mesh peers reporting the same model give 1, and two reporting different models give 2
- Two consultations through different adapters give 2
- reasoning check reports a stored conclusion whose count disagrees with its sources as a records finding
- Case 732's conclusion still records its computed count
Validace
- cargo test --manifest-path apps/majordomus-cli/Cargo.toml --lib reasoning
- bash test/run.sh 732_disagreement_is_settled_by_evidence 734_reasoning_survives_the_session
- majordomus reasoning check
Požadované důkazy
- duplicate_sources_are_one_review
Důkazy
Nic nezaznamenáno. Za každým tokenem výše musí stát příkaz nebo artefakt, než lze tento úkol dokončit; vyprávění se odmítá.
Časová osa
- zahájeno
- —
- ověřeno
- —
- dokončeno
- —
Tato tři pole, důkazy výše a stav závislostí jsou vše, z čeho se stav skládá. Neexistuje žádné pole stavu, které by s nimi mohlo být v rozporu.
Canonical record: .ai/repo/project/issues/I3419.yaml. Read it back with majordomus plan show I3419.